desaimom commented on code in PR #2447:
URL: https://github.com/apache/helix/pull/2447#discussion_r1176619084
##########
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java:
##########
@@ -432,6 +481,17 @@ protected Map<String, ResourceAssignment>
emergencyRebalance(
// Step 3: persist result to metadata store
persistBestPossibleAssignment(newAssignment);
+
+ // Step 4: handle delayed rebalance minActiveReplica
+ // Note this result is one step branching from the main calculation and
SHOULD NOT be persisted -- it is temporary,
+ // and only apply during the delayed window of those offline yet active
nodes, a definitive resolution will happen
+ // once the node comes back of remain offline after the delayed window.
+ Map<String, ResourceAssignment> assignmentWithDelayedRebalanceAdjust =
newAssignment;
+ if (_partialRebalanceRunner.isAsyncPartialRebalanceEnabled()) {
Review Comment:
Got it. I was talking about the method name. But I get your point. Async
vs/vs Sync.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
