jiajunwang commented on PR #2478: URL: https://github.com/apache/helix/pull/2478#issuecomment-1535593453
Actually, if you really want to make things straight, I would suggest changing the equal method, so different objects won't be equal and we can add another method just to compare replica's ID. But I forgot if any library code calls equal inside so we won't be able to promote the new equal method... Just my two cents. Overall performance is one of the most important things for the rebalancer and we cannot compromise. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
