Marcosrico commented on code in PR #2457:
URL: https://github.com/apache/helix/pull/2457#discussion_r1194394998
##########
meta-client/src/main/java/org/apache/helix/metaclient/factories/MetaClientFactory.java:
##########
@@ -32,6 +35,12 @@ public class MetaClientFactory {
private static final Logger LOG =
LoggerFactory.getLogger(MetaClientFactory.class);
public MetaClientInterface getMetaClient(MetaClientConfig config) {
+ if (config.getStoreType() == MetaClientConfig.StoreType.ZOOKEEPER) {
+ ZkMetaClientConfig zkMetaClientConfig = new
ZkMetaClientConfig.ZkMetaClientConfigBuilder().
Review Comment:
Yes good catch! I'll set all configurable fields from metaclientconfig when
creating a zkmetaclientconfig
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
