xyuanlu commented on code in PR #2488: URL: https://github.com/apache/helix/pull/2488#discussion_r1195688526
########## meta-client/src/main/java/org/apache/helix/metaclient/recipes/leaderelection/LeaderElectionListenerInterface.java: ########## @@ -0,0 +1,32 @@ +package org.apache.helix.metaclient.recipes.leaderelection; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/** + * It provides APIs for listener listening on events like a new leader is created or current + * leader node is deleted. + */ +public interface LeaderElectionListenerInterface { + // When new leader is elected: + // noLeader (null) -> has leader (new leader name) + // When existing leader not leader anymore: + // has Leader (prevleader name) -> no leader (null) + public void onLeadershipChange(String leaderPath, String prevLeader, String curLeader); Review Comment: As discussed offline. This API is more aligned with current use case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
