xyuanlu commented on code in PR #2535:
URL: https://github.com/apache/helix/pull/2535#discussion_r1231668317
##########
meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/util/ZkMetaClientUtil.java:
##########
@@ -262,6 +262,14 @@ public static MetaClientInterface.ConnectState
translateKeeperStateToMetaClientC
}
}
+ public static MetaClientInterface.Stat convertZkStatToStat(
+ org.apache.zookeeper.data.Stat zkStat) {
+ return new MetaClientInterface.Stat(
+ convertZkEntryModeToMetaClientEntryMode(zkStat.getEphemeralOwner()),
zkStat.getVersion(),
Review Comment:
exists(key) fetch stat from ZK and translate to MetaClientInterface.Stat.
The new API fetch data and stat in one go so no change happens in between.
Good point on code duplication, I will change `exists(key)` to use this
Util.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
