desaikomal commented on code in PR #2555:
URL: https://github.com/apache/helix/pull/2555#discussion_r1261336861
##########
meta-client/src/test/java/org/apache/helix/metaclient/impl/zk/TestZkMetaClient.java:
##########
@@ -504,6 +504,28 @@ public void handleDirectChildChange(String key) throws
Exception {
}
}
+ @Test
+ public void testChangeListener() throws Exception {
+ final String basePath = "/TestZkMetaClient_ChangeListener";
+ final int count = 100;
+ try (ZkMetaClient<String> zkMetaClient = createZkMetaClient()) {
+ zkMetaClient.connect();
+ DataChangeListener listener = new DataChangeListener() {
+
+ @Override
+ public void handleDataChange(String key, Object data, ChangeType
changeType)
+ throws Exception {
+ }
+ };
+ zkMetaClient.subscribeDataChange(basePath, listener, false);
Review Comment:
can we also have test case where persistent watcher is not set, and the test
still passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]