GrantPSpencer opened a new pull request, #2559:
URL: https://github.com/apache/helix/pull/2559
### Issues
Helix-rest's getClusterMaintenanceSignal will state the cluster is NOT in
maintenance node if the maintenance znode has no data. Another function,
getClusterMaintenanceMode, will return true in the above scenario.
### Description
- [ ] Here are some details about my PR, including screenshots of any UI
changes:
getClusterMaintenanceSignal currently attempts to retrieve the data of the
Maintenance znode and will return that the cluster was not in maintenance mode
if the returned data was null. This because dataAccessor.getProperty() will
return null if the key does not exist in the snapshot. However, the returned
value will also be null if the key corresponds to a null value.
We should bring the functionality of getClusterMaintenanceSignal inline with
getClusterMaintenanceMode, by first checking if the znode exists.
### Tests
- [ ] The following tests are written for this issue:
testEmptyMaintenanceSignal() in TestClusterAccessor.java
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous
assumptions for certain methods or API. They include:
N/A
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their
subject lines. In addition, my commits follow the guidelines from "[How to
write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
