xyuanlu commented on code in PR #2560:
URL: https://github.com/apache/helix/pull/2560#discussion_r1269026448
##########
meta-client/src/main/java/org/apache/helix/metaclient/recipes/leaderelection/LeaderElectionClient.java:
##########
@@ -288,7 +289,8 @@ public List<String> getParticipants(String leaderPath) {
* @return A boolean value indicating if registration is success.
*/
public boolean subscribeLeadershipChanges(String leaderPath,
LeaderElectionListenerInterface listener) {
- //TODO: add converter class for LeaderElectionListenerInterface
+ _metaClient.subscribeDataChange(leaderPath + "/LEADER", new
LeaderElectionListenerInterfaceAdapter(listener),
+ false);
Review Comment:
It is persist watcher. If the ephemeral node is gone, then is the watcher
still valid and receive new leader acquired notification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
