desaikomal commented on code in PR #2562:
URL: https://github.com/apache/helix/pull/2562#discussion_r1269540527
##########
meta-client/src/main/java/org/apache/helix/metaclient/api/MetaClientInterface.java:
##########
@@ -202,6 +202,14 @@ public Stat (EntryMode mode, int version, long ctime, long
mtime, long etime) {
*/
T get(final String key);
+ /**
+ * Fetch the data for a given key.
+ * @param key key to identify the entry
+ * @param returnNullIfPathNotExists throws MetaClientNoNodeException if no
node when set to false;
+ * @return Return data of the entry.
+ */
+ T get(String key, boolean returnNullIfPathNotExists);
Review Comment:
+1. The above "get" method states it will return null if key doesn't exist.
##########
meta-client/src/main/java/org/apache/helix/metaclient/recipes/leaderelection/LeaderElectionClient.java:
##########
@@ -136,27 +139,63 @@ public void joinLeaderElectionParticipantPool(String
leaderPath) {
public void joinLeaderElectionParticipantPool(String leaderPath, LeaderInfo
userInfo) {
// TODO: create participant entry with info
Review Comment:
ditto
##########
meta-client/src/main/java/org/apache/helix/metaclient/recipes/leaderelection/LeaderElectionClient.java:
##########
@@ -123,6 +125,7 @@ public boolean isLeader(String leaderPath) {
public void joinLeaderElectionParticipantPool(String leaderPath) {
// TODO: create participant entry
Review Comment:
nit: remove TODO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
