desaikomal opened a new pull request, #2567: URL: https://github.com/apache/helix/pull/2567
### Issues - [ ] My PR addresses the following Helix issues and references them in the PR description: N/A ### Description - [x] Here are some details about my PR, including screenshots of any UI changes: In change: https://github.com/apache/helix/pull/2546 in method, processPendingMessage() - i was processing upward ST but my condition assumed that we are bootstrapping from INIT to OFFLINE and that's when space should be accounted for. When Espresso team did the experiment, realized that bootstrapping is actually OFFLINE to SLAVE. So instead of looking at message.ToState(), should be looking at message.FromState(). Since this feature is not yet mature, adding a bit more logs to help in debugging the failures. Once this has been validated, will convert the info() messages to debug() messages. ### Tests - [] The following tests are written for this issue: (List the names of added unit/integration tests) - The following is the result of the "mvn test" command on the appropriate module: mvn test is in progres, will update it. ### Changes that Break Backward Compatibility (Optional) - My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include: (Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.) ### Documentation (Optional) - In case of new functionality, my PR adds documentation in the following wiki page: (Link the GitHub wiki you added) ### Commits - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org
