Marcosrico opened a new pull request, #2579: URL: https://github.com/apache/helix/pull/2579
### Issues - [ ] My PR addresses the following Helix issues and references them in the PR description: There was a race condition where the threads running the specific puppies would terminate, leading to the created znodes to be deleted. Because there were listeners on those nodes, they would increase the event change counter when the threads had already finished, causing the tests to fail. Code cleanup stems from bug: https://github.com/apache/helix/issues/2577 ### Description - [ ] Here are some details about my PR, including screenshots of any UI changes: Removed the cleanup section of the CRUD puppies (as cleanup will happen in the test case). Many of the cleanups weren't necessary and the ones that were (for CreatePuppy) was what caused the race condition. Re-structured code in AbstractPuppy for less redundancy and modified some print statements for easier readability. ### Tests - [ ] The following tests are written for this issue: TestMultiThreadStressZKClient.java - The following is the result of the "mvn test" command on the appropriate module: (If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.) ### Commits - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
