xyuanlu commented on PR #2585: URL: https://github.com/apache/helix/pull/2585#issuecomment-1675176451
> A general and maybe dumb question, how would there be double leader? Does the old leader still acts as leader while disconnected from the metadata store, meanwhile a real new leader is elected? Thanks @qqu0127 for review! Before this PR, client send `leader gone` event to registered listeners when it gets `Node deleted` event. In case of disconnect, client will only get `Node deleted` event when it reconnected to ZK. If disconnect time is longer than session expire time, a new leader will already be selected and client gets `Node deleted` event after that. In this change we proactively send `leader gone` event to registered listeners when we get disconnected event and touch leader ZNode when it reconnect. <img width="845" alt="Screenshot 2023-08-11 at 11 01 18 AM" src="https://github.com/apache/helix/assets/6392021/047518df-11df-43a0-a790-7628d2483e9f";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
