desaikomal commented on code in PR #2591:
URL: https://github.com/apache/helix/pull/2591#discussion_r1293586943
##########
helix-core/src/main/java/org/apache/helix/controller/stages/TopStateHandoffReportStage.java:
##########
@@ -491,6 +491,12 @@ private void
reportTopStateComesBack(ResourceControllerDataProvider cache, Map<S
true);
}
}
+
+ // In case of recovery after failure, we should decrement the
missingTopStateBeyondThresholdGauge value.
+ if (clusterStatusMonitor != null && record.isFailed()) {
Review Comment:
First and foremost, congratulations on your first change.
Q: why do we decrement only for recovery after failure scenario and not
in-general recovery?
Q: why don't i see change for 1min related reset window?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
