desaikomal commented on code in PR #2591:
URL: https://github.com/apache/helix/pull/2591#discussion_r1293879742
##########
helix-core/src/main/java/org/apache/helix/controller/stages/TopStateHandoffReportStage.java:
##########
@@ -491,6 +491,12 @@ private void
reportTopStateComesBack(ResourceControllerDataProvider cache, Map<S
true);
}
}
+
+ // In case of recovery after failure, we should decrement the
missingTopStateBeyondThresholdGauge value.
+ if (clusterStatusMonitor != null && record.isFailed()) {
Review Comment:
Had offline conversation. A: to first one is that whenever we cross
threshold, we mark it FAILED.
A: to the second one is:this is generic reset - not specific to the metric
in question.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
