xyuanlu commented on code in PR #2597:
URL: https://github.com/apache/helix/pull/2597#discussion_r1302231364
##########
helix-core/src/test/java/org/apache/helix/controller/strategy/crushMapping/TestCardDealingAdjustmentAlgorithmV2.java:
##########
@@ -187,9 +189,11 @@ public static Object[][] stableComputingVerification() {
};
}
- @Test(description = "Compute mapping multiple times, the mapping of each
time should be same", dataProvider = "stableComputingVerification")
+ @Test(description = "Compute mapping multiple times, the mapping of each
time should be same", dataProvider = "stableComputingVerification",
+ dependsOnMethods = "testAlgorithmConstructor")
public void testStableComputeMappingForMultipleTimes(int replica, int
repeatTimes, int seed,
boolean isEvennessPreferred) {
+ System.out.println("START
TestCardDealingAdjustmentAlgorithmV2.testStableComputeMappingForMultipleTimes");
Review Comment:
Thanks for the suggestion. I think normally we just use the plan text test
func name to reduce string append.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
