zpinto commented on code in PR #2601:
URL: https://github.com/apache/helix/pull/2601#discussion_r1302258998


##########
helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/ClusterAccessor.java:
##########
@@ -244,6 +244,10 @@ public Response updateCluster(@PathParam("clusterId") 
String clusterId,
     ClusterSetup clusterSetup = getClusterSetup();
     HelixAdmin helixAdmin = getHelixAdmin();
 
+    if (!doesClusterExist(clusterId)) {

Review Comment:
   Will this cause an issue if the caller is attempting to use the "activate" 
command? What is the response if the cluster isn't activated?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to