zpinto commented on code in PR #2610:
URL: https://github.com/apache/helix/pull/2610#discussion_r1312082626
##########
helix-core/src/test/java/org/apache/helix/controller/stages/BaseStageTest.java:
##########
@@ -209,7 +210,11 @@ protected void runStage(ClusterEvent event, Stage stage) {
stage.init(context);
stage.preProcess();
try {
- stage.process(event);
+ if (stage instanceof AbstractAsyncBaseStage) {
+ ((AbstractAsyncBaseStage) stage).execute(event);
Review Comment:
This is necessary to execute the business logic of any async stage because
that logic is in execute method instead of process method since
AbstractAsyncStage overrides the process method to run execute on async worker.
TestAsyncBaseStage tests AbstractAsyncStage's process method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
