Marcosrico commented on PR #2612: URL: https://github.com/apache/helix/pull/2612#issuecomment-1710818643
After an offline discussion we agreed on a couple comments for this design: 1. There is no need for the apis (start, close, and rebuild cache) in the MetaClientCacheInterface, as those methods are essentially done in the original MetaClientCache that such extends. Thus, we can safely remove the need for a cache interface. 2. Instead, we will add a cache field to the metaclientconfig and the builder that will create an instance of the zkmetaclientcache if enabled. 3. There is also no need to expose the state of the cache to the user. The api contract is pre-defined and so whether the state of the cache is up-to-date or not is not needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
