junkaixue commented on code in PR #2615:
URL: https://github.com/apache/helix/pull/2615#discussion_r1324845689


##########
helix-core/src/main/java/org/apache/helix/controller/rebalancer/DelayedAutoRebalancer.java:
##########
@@ -193,6 +197,14 @@ public IdealState computeNewIdealState(String resourceName,
     return idealState;
   }
 
+  public static List<String> filterOutEvacuatingInstances(Map<String, 
InstanceConfig> instanceConfigMap,
+      Set<String> nodes) {
+    return  nodes.stream()
+        .filter(instance -> 
!instanceConfigMap.get(instance).getInstanceOperation().equals(
+            InstanceConstants.InstanceOperation.EVACUATE.name()))

Review Comment:
   Let's include the SWAP_IN as well. It will be same behavior.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to