junkaixue commented on code in PR #2609:
URL: https://github.com/apache/helix/pull/2609#discussion_r1329330542
##########
helix-core/src/main/java/org/apache/helix/model/InstanceConfig.java:
##########
@@ -253,7 +254,8 @@ public boolean containsTag(String tag) {
* @return true if enabled, false if disabled
*/
public boolean getInstanceEnabled() {
- return
_record.getBooleanField(InstanceConfigProperty.HELIX_ENABLED.toString(), true);
+ return
_record.getBooleanField(InstanceConfigProperty.HELIX_ENABLED.toString(),
Review Comment:
NIT: since you change the line, would be good to have name() for toString()
as overall replacement for all the code when you change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
