xyuanlu commented on code in PR #2619:
URL: https://github.com/apache/helix/pull/2619#discussion_r1335094618
##########
meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClientCache.java:
##########
@@ -43,11 +44,10 @@ public class ZkMetaClientCache<T> extends ZkMetaClient<T>
implements MetaClientC
private ChildChangeListener _eventListener;
private boolean _cacheData;
private boolean _cacheChildren;
- private boolean _lazyCaching;
private static final Logger LOG =
LoggerFactory.getLogger(ZkMetaClientCache.class);
private ZkClient _cacheClient;
-
private ExecutorService executor;
+ private final CountDownLatch latch = new CountDownLatch(1);
Review Comment:
Since only we need one count down, see if we could use conditional variable.
Also better naming please. :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
