himanshukandwal opened a new pull request, #2639:
URL: https://github.com/apache/helix/pull/2639
### Issues
- [x] My PR addresses the following Helix issues and references them in the
PR description:
#2638
### Description
- [x] Here are some details about my PR, including screenshots of any UI
changes:
Where the Hard Constraint fails, the error message is very generic and it
doesn't give much information on which capacity dimension failed and with what
values.
In this PR, we instead of returning a boolean result, we are returning
ValidationResult class object that contains whether the validation has passed
or not, and if not it will also contain an additional error-message.
### Tests
- [x] The following tests are written for this issue:
Improved Following Tests classes:
* TestConstraintBasedAlgorithm
* TestFaultZoneAwareConstraint
* TestNodeCapacityConstraint
* TestNodeMaxPartitionLimitConstraint
* TestPartitionActivateConstraint
* TestReplicaActivateConstraint
* TestSamePartitionOnInstanceConstraint
* TestValidGroupTagConstraint
- The following is the result of the "mvn test" command on the appropriate
module:
``` console
END testMsgConstraint() at Tue Oct 03 10:59:40 PDT 2023
START testStateConstraint() at Tue Oct 03 10:59:40 PDT 2023
{RESOURCE=TestDB, STATE=MASTER} matches(3): [{STATE=MASTER}:1,
{STATE=MASTER, RESOURCE=TestDB}:1, {STATE=MASTER, RESOURCE=.*}:2]
{RESOURCE=MyDB, STATE=MASTER} matches(2): [{STATE=MASTER}:1, {STATE=MASTER,
RESOURCE=.*}:2]
END testStateConstraint() at Tue Oct 03 10:59:40 PDT 2023
AfterClass: TestConstraint called.
Shut down zookeeper at port 2183 in thread main
[INFO] Tests run: 32, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
16.234 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 32, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] --- jacoco:0.8.6:report (generate-code-coverage-report) @ helix-core
---
[INFO] Loading execution data file
/Users/hkandwal/Documents/workspaces/projects/helix_os_hk/helix-core/target/jacoco.exec
[INFO] Analyzed bundle 'Apache Helix :: Core' with 949 classes
[INFO]
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 21.203 s
[INFO] Finished at: 2023-10-03T10:59:42-07:00
[INFO]
------------------------------------------------------------------------
```
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous
assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also
include these changes in merge description so that other developers are aware
of these changes. This allows them to make relevant code changes in feature
branches accounting for the new method/API behavior.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following
wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their
subject lines. In addition, my commits follow the guidelines from "[How to
write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
