himanshukandwal opened a new pull request, #2675:
URL: https://github.com/apache/helix/pull/2675
### Issues
- [x] My PR addresses the following Helix issues and references them in the
PR description:
#2674
### Description
Currently, WAGED consider both many capacity categories/dimensions for
evenness scores for the placement decision. In some use case, only one key
should be relevant for evenness scores. Because, all the clusters are
over-provisioned based on that category, and if evenness scores are not based
on that then it introduces more movements.
So, we would like to provide a way for users to specify a prioritized
evennessScoringKey that will help computing scores based on that category only.
### Tests
- [x] The following tests are written for this issue:
* TestMaxCapacityUsageInstanceConstraint
* testGetNormalizedScoreWithPrioritizedKey
* TestTopStateMaxCapacityUsageInstanceConstraint
* testGetNormalizedScoreWithPrioritizedKey
- The following is the result of the "mvn test" command on the appropriate
module:
```console
mvn test -o "-Dtest=Test*Constraint" -pl=helix-core
[INFO] Tests run: 32, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
15.742 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 32, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] --- jacoco:0.8.6:report (generate-code-coverage-report) @ helix-core
---
[INFO] Loading execution data file
/Users/hkandwal/Documents/workspaces/projects/helix_os_hk/helix-core/target/jacoco.exec
[INFO] Analyzed bundle 'Apache Helix :: Core' with 947 classes
[INFO]
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 27.529 s
[INFO] Finished at: 2023-10-19T07:50:37-07:00
[INFO]
------------------------------------------------------------------------
```
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous
assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also
include these changes in merge description so that other developers are aware
of these changes. This allows them to make relevant code changes in feature
branches accounting for the new method/API behavior.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following
wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their
subject lines. In addition, my commits follow the guidelines from "[How to
write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
