xyuanlu commented on code in PR #2654:
URL: https://github.com/apache/helix/pull/2654#discussion_r1366208302
##########
helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/InstancesAccessor.java:
##########
@@ -198,7 +194,7 @@ public Response instancesOperations(@PathParam("clusterId")
String clusterId,
break;
case stoppable:
return batchGetStoppableInstances(clusterId, node, skipZKRead,
continueOnFailures,
- skipHealthCheckCategorySet);
Review Comment:
Also add sanity check when random and zone order is set at same time.
##########
helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/InstancesAccessor.java:
##########
@@ -198,7 +194,7 @@ public Response instancesOperations(@PathParam("clusterId")
String clusterId,
break;
case stoppable:
return batchGetStoppableInstances(clusterId, node, skipZKRead,
continueOnFailures,
- skipHealthCheckCategorySet);
Review Comment:
comment about default value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
