MarkGaox commented on code in PR #2680:
URL: https://github.com/apache/helix/pull/2680#discussion_r1374859529
##########
helix-core/src/main/java/org/apache/helix/util/InstanceValidationUtil.java:
##########
@@ -370,7 +370,8 @@ public static boolean isInstanceStable(HelixDataAccessor
dataAccessor, String in
* @param instanceName
* @return
*/
- public static boolean siblingNodesActiveReplicaCheck(HelixDataAccessor
dataAccessor, String instanceName) {
+ public static boolean siblingNodesActiveReplicaCheck(HelixDataAccessor
dataAccessor,
+ String instanceName, Set<String> toBeStoppedInstances) {
Review Comment:
Added two methods: `siblingNodesActiveReplicaCheck(HelixDataAccessor
dataAccessor, String instanceName)` and
`perPartitionHealthCheck(List<ExternalView> externalViews,
Map<String, Map<String, Boolean>> globalPartitionHealthStatus, String
instanceToBeStop,
HelixDataAccessor dataAccessor)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
