zpinto opened a new pull request, #2688: URL: https://github.com/apache/helix/pull/2688
### Issues - [x] Fix condition to check if DOMAIN has all required TOPOLOGY keys and allows for extra kv pairs, to reduce noisy logs. (#200 - Link your issue number here: You can write "Fixes #XXX". Please use the proper keyword so that the issue gets closed automatically. See https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue Any of the following keywords can be used: close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved) ### Description When DOMAIN has more kv pairs than the ones required in TOPOLOGY(non-WAGED cases only), we log an incorrect warn message. When there are extra kv pairs, this check to see if numOfMatchedKeys == domainAsMap.size() is false because not all keys in DOMAIN are used. This leads to huge log flooding. The check above is incorrect, as it should be okay to have extra kv pairs in DOMAIN as long as the required kv pairs exist. The check should be (numOfMatchedKeys < clusterTopologyConfig.getTopologyKeyDefaultValue().size()), so it only warns if DOMAIN does not contain the required topology keys. ### Tests Current tests should cover this. ### Changes that Break Backward Compatibility (Optional) NA ### Documentation (Optional) NA ### Commits - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
