csudharsanan opened a new pull request, #2696:
URL: https://github.com/apache/helix/pull/2696
### Issues
- [ ] My PR addresses the following Helix issues and references them in the
PR description:
fixes #2695
### Description
- [ ] When we encounter any Throwable Error like OOME, we do not handle it
currently. We should ideally cleanup ZK state (remove the message) and allow
Helix to continue working on failed task. Clean-up and retry code path should
be executed on encountering Throwable of any type.
### Tests
- [ ] TestHelixTaskExecutor:
- testThrowableHandlingOnMessageProcess
```
[INFO] Reactor Summary for Apache Helix 1.3.2-SNAPSHOT:
[INFO]
[INFO] Apache Helix ....................................... SUCCESS [ 1.793
s]
[INFO] Apache Helix :: Metrics Common ..................... SUCCESS [ 2.393
s]
[INFO] Apache Helix :: Metadata Store Directory Common .... SUCCESS [ 1.479
s]
[INFO] Apache Helix :: ZooKeeper API ...................... SUCCESS [ 3.975
s]
[INFO] Apache Helix :: Helix Common ....................... SUCCESS [ 1.533
s]
[INFO] Apache Helix :: Core ............................... SUCCESS [ 24.984
s]
[INFO] Apache Helix :: Admin Webapp ....................... SUCCESS [ 2.978
s]
[INFO] Apache Helix :: Restful Interface .................. SUCCESS [ 5.904
s]
[INFO] Apache Helix :: Distributed Lock ................... SUCCESS [ 1.160
s]
[INFO] Apache Helix :: HelixAgent ......................... SUCCESS [ 1.959
s]
[INFO] Apache Helix :: Front End .......................... SUCCESS [03:20
min]
[INFO] Apache Helix :: Recipes ............................ SUCCESS [ 0.031
s]
[INFO] Apache Helix :: Recipes :: Rabbitmq Consumer Group . SUCCESS [ 1.484
s]
[INFO] Apache Helix :: Recipes :: Rsync Replicated File Store SUCCESS [
1.493 s]
[INFO] Apache Helix :: Recipes :: distributed lock manager SUCCESS [ 1.121
s]
[INFO] Apache Helix :: Recipes :: distributed task execution SUCCESS [
1.137 s]
[INFO] Apache Helix :: Recipes :: service discovery ....... SUCCESS [ 1.030
s]
[INFO] Apache Helix :: View Aggregator .................... SUCCESS [ 2.253
s]
[INFO] Apache Helix :: Meta Client ........................ SUCCESS [ 2.138
s]
[INFO]
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 04:20 min
[INFO] Finished at: 2023-11-07T19:21:16-08:00
[INFO]
------------------------------------------------------------------------
```
```
[INFO] Tests run: 20, Failures: 0, Errors: 0, Skipped: 0, Time elapsed:
47.314 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 20, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO]
[INFO] --- jacoco:0.8.6:report (generate-code-coverage-report) @ helix-core
---
[INFO] Loading execution data file
/Users/csudhars/Documents/GitHub/csudharsanan_helix/helix/helix-core/target/jacoco.exec
[INFO] Analyzed bundle 'Apache Helix :: Core' with 947 classes
[INFO]
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 01:04 min
[INFO] Finished at: 2023-11-07T19:24:28-08:00
[INFO]
------------------------------------------------------------------------
```
- The following is the result of the "mvn test" command on the appropriate
module:
(If CI test fails due to known issue, please specify the issue and test PR
locally. Then copy & paste the result of "mvn test" to here.)
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous
assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also
include these changes in merge description so that other developers are aware
of these changes. This allows them to make relevant code changes in feature
branches accounting for the new method/API behavior.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following
wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their
subject lines. In addition, my commits follow the guidelines from "[How to
write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
