desaikomal commented on code in PR #2698:
URL: https://github.com/apache/helix/pull/2698#discussion_r1394812589


##########
helix-lock/src/test/java/org/apache/helix/lock/helix/TestZKHelixNonblockingLockWithPriority.java:
##########
@@ -81,6 +81,45 @@ public void afterSuite() throws IOException {
     super.afterSuite();
   }
 
+  @Test

Review Comment:
   not sure if we want to add a test case, where our user are using the old 
default priority (-1) for creating the lock and then re-acquire the lock or 
releae the lock, will it work? Essentially, we need to fix for customers who 
have been using with broken code also.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to