zpinto opened a new pull request, #2706: URL: https://github.com/apache/helix/pull/2706
### Issues Make logic to determine state of replicas on SWAP_IN instance simpler and more predictable during an in-flight node swap. ### Description Changing state assignment logic for replicas on swap in node to only be assigned top state if the state model says that all replicas or all candidate nodes can have the top state. All other cases will have the second top state assigned. Also, moving N and R to constants and updating code where necessary. ### Tests - Current tests cover this change. ### Changes that Break Backward Compatibility (Optional) NA ### Commits - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
