desaikomal commented on code in PR #2696:
URL: https://github.com/apache/helix/pull/2696#discussion_r1412266692
##########
helix-core/src/main/java/org/apache/helix/util/StatusUpdateUtil.java:
##########
@@ -406,6 +406,15 @@ public void logError(Message message, Class classInfo,
Exception e, String addit
additionalInfo + sw.toString(), manager);
}
+ public void logError(Message message, Class classInfo, Throwable t, String
additionalInfo,
Review Comment:
this may not be required. let us use existing one where the additional info
as 'T' info.
##########
helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java:
##########
@@ -488,11 +490,11 @@ public boolean scheduleTask(MessageTask task) {
"Message handling task already sheduled for " + taskId, manager);
}
}
- } catch (Exception e) {
+ } catch (Throwable e) {
LOG.error("Error while executing task. " + message, e);
_statusUpdateUtil
- .logError(message, HelixTaskExecutor.class, e, "Error while
executing task " + e,
- manager);
+ .logError(message, HelixTaskExecutor.class, e, "Error while
executing task. " + e,
Review Comment:
wondering if we can use the existing .logError as you are already printing
'e' as part of the additionalInfo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
