himanshukandwal opened a new pull request, #2708: URL: https://github.com/apache/helix/pull/2708
### Issues - [x] My PR addresses the following Helix issues and references them in the PR description: One of our consumers notified us that they need certain handoff related log lines from controller side so as to identify the partition names, post which investigation can be resumed from consumer side to locate the reason for the longer handoff. ### Description - [x] Here are some details about my PR, including screenshots of any UI changes: In this PR we are changing the log level of a critical unrecovered handoff log statement to INFO from DEBUG. This log statement was moved to debug when the TopStateHandoffReportStage was taking longer time. This stage has now been moved to async and the occurences of unrecovered handoffs are very few as high thresholds has been set by our consumers. But, when this threshold gets breached we would like to see this log statement. In longer term, we have understood this this information should be provided in some other way and reliance on log statement is not good for long term. ### Tests - [x] The following tests are written for this issue: This PR just includes change of log level, so used existing unit tests. - The following is the result of the "mvn test" command on the appropriate module: ```console mvn clean install -Dmaven.test.skip.exec=true && mvn test -o -Dtest=TestTopStateHandoffMetrics -pl=helix-core [INFO] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 20.198 s - in org.apache.helix.monitoring.mbeans.TestTopStateHandoffMetrics [INFO] [INFO] Results: [INFO] [INFO] Tests run: 12, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] [INFO] --- jacoco:0.8.6:report (generate-code-coverage-report) @ helix-core --- [INFO] Loading execution data file /Users/hkandwal/Documents/workspaces/projects/helix_os_hk/helix-core/target/jacoco.exec [INFO] Analyzed bundle 'Apache Helix :: Core' with 947 classes [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 30.989 s [INFO] Finished at: 2023-12-04T15:43:03-08:00 [INFO] ------------------------------------------------------------------------ ``` (If CI test fails due to known issue, please specify the issue and test PR locally. Then copy & paste the result of "mvn test" to here.) ### Changes that Break Backward Compatibility (Optional) - My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include: (Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.) ### Documentation (Optional) - In case of new functionality, my PR adds documentation in the following wiki page: (Link the GitHub wiki you added) ### Commits - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
