xyuanlu commented on code in PR #2699:
URL: https://github.com/apache/helix/pull/2699#discussion_r1418463005
##########
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/constraints/MaxCapacityUsageInstanceConstraint.java:
##########
@@ -31,13 +33,17 @@
* It is a greedy approach since it evaluates only on the most used capacity
key.
*/
class MaxCapacityUsageInstanceConstraint extends UsageSoftConstraint {
+ private static final Logger LOG =
LoggerFactory.getLogger(MaxCapacityUsageInstanceConstraint.class.getName());
@Override
protected double getAssignmentScore(AssignableNode node, AssignableReplica
replica,
ClusterContext clusterContext) {
float estimatedMaxUtilization =
clusterContext.getEstimatedMaxUtilization();
float projectedHighestUtilization =
- node.getGeneralProjectedHighestUtilization(replica.getCapacity());
- return computeUtilizationScore(estimatedMaxUtilization,
projectedHighestUtilization);
+ node.getGeneralProjectedHighestUtilization(replica.getCapacity(),
clusterContext.getPreferredScoringKey());
+ double utilizationScore = computeUtilizationScore(estimatedMaxUtilization,
projectedHighestUtilization);
+ LOG.info("[DEPEND-29018] clusterName: {}, estimatedMaxUtilization: {},
projectedHighestUtilization: {}, utilizationScore: {}, preferredScoringKey: {}",
Review Comment:
Please consider avoiding include user specific ticket here. We want Helix
to be a generic service.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
