junkaixue commented on code in PR #2708:
URL: https://github.com/apache/helix/pull/2708#discussion_r1419679495
##########
helix-core/src/main/java/org/apache/helix/controller/stages/TopStateHandoffReportStage.java:
##########
@@ -106,6 +107,7 @@ private void
updateTopStateStatus(ResourceControllerDataProvider cache,
}
String resourceName = resource.getResourceName();
+ ImmutableMap.Builder<String, Long> failingPartitionsInfoCollector =
ImmutableMap.builder();
Review Comment:
Let's not recreate this object. We can just make it a private member for
this class. Every pipeline we clear it at beginning instead recreate the object
every time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
