csudharsanan commented on code in PR #2696:
URL: https://github.com/apache/helix/pull/2696#discussion_r1420450803
##########
helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java:
##########
@@ -488,11 +490,11 @@ public boolean scheduleTask(MessageTask task) {
"Message handling task already sheduled for " + taskId, manager);
}
}
- } catch (Exception e) {
+ } catch (Throwable e) {
Review Comment:
updated variable name to t. Since OOME encountered in this GCN is an error,
we had to update this to throwable instead of Exception.
OOME has following lineage:
> java.lang.Throwable
-->java.lang.Error
-->java.lang.VirtualMachineError
--->java.lang.OutOfMemoryError
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
