zpinto commented on code in PR #2712:
URL: https://github.com/apache/helix/pull/2712#discussion_r1425689442
##########
helix-core/src/main/java/org/apache/helix/controller/rebalancer/topology/Topology.java:
##########
@@ -57,8 +58,19 @@ public enum Types {
private final Map<String, InstanceConfig> _instanceConfigMap;
private final ClusterTopologyConfig _clusterTopologyConfig;
+ /**
+ * Create a Topology for a cluster.
+ *
+ * @param allNodes allNodes of the given cluster.
+ * @param liveNodes liveNodes of the given cluster.
+ * @param instanceConfigMap instanceConfigMap of the given cluster.
+ * @param clusterConfig clusterConfig of the given cluster.
+ * @param faultZoneLevelOnly whether to include additional non-faultZone
level nodes in the
+ * topology tree above the end-nodes.
+ */
public Topology(final List<String> allNodes, final List<String> liveNodes,
- final Map<String, InstanceConfig> instanceConfigMap, ClusterConfig
clusterConfig) {
+ final Map<String, InstanceConfig> instanceConfigMap, ClusterConfig
clusterConfig,
+ boolean faultZoneLevelOnly) {
Review Comment:
Yes, that is correct; however, this constructor is public and may be used
outside our code base by others.
This will keep backwards compatibility, while only changing the behavior of
the rebalancer to limit the backwards incompatibility concerns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
