junkaixue commented on code in PR #2727:
URL: https://github.com/apache/helix/pull/2727#discussion_r1450966051
##########
.github/workflows/Helix-Manual-CI.yml:
##########
@@ -24,16 +26,27 @@ jobs:
- uses: actions/checkout@v2
with:
ref: ${{ github.event.inputs.buildRef }}
- - name: Set up JDK 1.8
+ - name: Set up JDK 11
uses: actions/setup-java@v1
with:
- java-version: 1.8
+ java-version: 11
- name: Delete frontend-maven-plugin dir
run: rm -rf .m2\repository\com\github\eirslett
- name: Build with Maven
run: mvn clean install -Dmaven.test.skip.exec=true
-DretryFailedDeploymentCount=5
- name: Run All Tests
run: mvn -B -V -e -ntp "-Dstyle.color=always" ${{
github.event.inputs.mvnOpts }} ${{ github.event.inputs.goals }}
- - name: Print Tests Results
- run: .github/scripts/printTestResult.sh
- if: ${{ success() || failure() }}
+ - name: Test Report
+ uses: dorny/test-reporter@v1
+ if: always()
+ with:
+ name: Tests Results
+ path: './**/target/surefire-reports/TEST-TestSuite.xml'
+ reporter: java-junit
+ - name: Upload unit test results
+ if: failure()
+ uses: actions/upload-artifact@v2
+ with:
+ name: surefire-reports
+ path: ./**/target/surefire-reports/
+ if-no-files-found: ignore
Review Comment:
NIT: extra new line can avoid this kind of symbol.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
