zpinto opened a new pull request, #2741: URL: https://github.com/apache/helix/pull/2741
### Issues - [x] Fix SWAP to respect instance disabled state to send all assigned partitions to OFFLINE state. SWAP_IN instance will still have the same assignment as SWAP_OUT instance. - [x] Remove unnecessary logic to handle SWAP_IN node in preferenceList, this was from old approach. ### Description Previously, when a swap is initiated and the swap-in node has HELIX_ENABLED set to false, the replicas assigned to it are not sent to the OFFLINE state. In order to align with the behavior of HELIX_ENABLED = false, we will now send all assigned replicas to OFFLINE state. When the SWAP_IN instance is re-enabled, it will receive upward state transitions for its replicas. ### Tests - [x] Add test testNodeSwapDisableAndReenable ### Changes that Break Backward Compatibility (Optional) Removed some public methods; however, they were not in an open source release and would likely cause more confusion if they were left. ### Documentation (Optional) NA ### Commits - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
