zpinto commented on code in PR #2738:
URL: https://github.com/apache/helix/pull/2738#discussion_r1466785643
##########
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterContext.java:
##########
@@ -57,20 +63,29 @@ public class ClusterContext {
private final Map<String, Integer> _estimateUtilizationMap;
// Cluster total capacity. Used to compute score when sorting replicas.
private final Map<String, Integer> _clusterCapacityMap;
-
+ private final List<String> _preferredScoringKey;
Review Comment:
Here and in other places, I am a bit confused whey we refer to it as
`preferedScoringKey` instead of `preferedScoringKeys` if the user is able to
configure multiple scoring keys in the ClusterConfig.
Should we consider changing this to plural for clarity?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
