desaikomal commented on code in PR #2740:
URL: https://github.com/apache/helix/pull/2740#discussion_r1470162820
##########
helix-core/src/main/java/org/apache/helix/controller/dataproviders/BaseControllerDataProvider.java:
##########
@@ -127,7 +127,9 @@ public class BaseControllerDataProvider implements
ControlContextProvider {
private final Set<String> _enabledLiveSwapInInstanceNames = new HashSet<>();
private final Map<String, MonitoredAbnormalResolver>
_abnormalStateResolverMap = new HashMap<>();
private final Set<String> _timedOutInstanceDuringMaintenance = new
HashSet<>();
- private Map<String, LiveInstance> _liveInstanceExcludeTimedOutForMaintenance
= new HashMap<>();
+ private Map<String, LiveInstance>
_allLiveInstanceExcludeTimedOutForMaintenance = new HashMap<>();
+ private Map<String, LiveInstance>
_assignableLiveInstanceExcludeTimedOutForMaintenance =
+ new HashMap<>();
Review Comment:
_allLive vs/vs assignable - may be i am wrong here - but can't we just keep
the "string" of nodes instead of the whole hashmap, also isn't there another
structure which maintains this list?
##########
helix-core/src/main/java/org/apache/helix/controller/dataproviders/BaseControllerDataProvider.java:
##########
@@ -127,7 +127,9 @@ public class BaseControllerDataProvider implements
ControlContextProvider {
private final Set<String> _enabledLiveSwapInInstanceNames = new HashSet<>();
private final Map<String, MonitoredAbnormalResolver>
_abnormalStateResolverMap = new HashMap<>();
private final Set<String> _timedOutInstanceDuringMaintenance = new
HashSet<>();
- private Map<String, LiveInstance> _liveInstanceExcludeTimedOutForMaintenance
= new HashMap<>();
+ private Map<String, LiveInstance>
_allLiveInstanceExcludeTimedOutForMaintenance = new HashMap<>();
Review Comment:
It may be just me, but what does 'TimedOutForMaintenance' mean over here?
you want to exclude certain instances but what those are
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
