zpinto opened a new pull request, #2755: URL: https://github.com/apache/helix/pull/2755
### Issues - [x] Add ability to use Evac + Add to swap instances with same logicalId - [x] Add ability to complete swap when swap out instance goes offline or is disabled - [x] Don't have downward ST on SWAP_IN node when SWAP_OUT goes offline or is disabled (Only allow when replica is dropped from SWAP_OUT during swap) ### Description Modify the behavior of swap to continue bootstrapping second or top state on the swap in node regardless of if the swap out node is disabled or offline. We don't want either of those two cases to nullify the work already done during the swap. Modify HelixAdmin to allow evacuation to be used with adding a new instance with the same logicalId and allow for swap to complete when swap out instance is offline or disabled. ### Tests - [x] testNodeSwapWithSwapOutInstanceOffline - [x] testNodeSwapWithSwapOutInstanceDisabled - [x] testNodeSwapAddSwapInFirst (had to remove the ability to do this to support two paths for evacuate) - [x] testSwapEvacuateAdd - [x] testSwapEvacuateAddRemoveEvacuate ### Commits - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - My diff has been formatted using helix-style.xml (helix-style-intellij.xml if IntelliJ IDE is used) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
