GrantPSpencer opened a new pull request, #2769:
URL: https://github.com/apache/helix/pull/2769
### Issues
- [ ] My PR addresses the following Helix issues and references them in the
PR description:
GenericLeaderStandby is a legacy statemodel used by HelixCustomCodeRunner.
It does not specify transition methods for the following:
OFFLINE --> DROPPED
DROPPED --> OFFLINE
ERROR --> OFFLINE
HelixCustomCodeRunner registers this statemodel factory but specifies
"LeaderStandby" as the stateModelDefRef, which can have dropped as a valid
state.
```
private static final String LEADER_STANDBY = "LeaderStandby";
...
_stateModelFty = new GenericLeaderStandbyStateModelFactory(_callback,
_notificationTypes);
StateMachineEngine stateMach = _manager.getStateMachineEngine();
stateMach.registerStateModelFactory(LEADER_STANDBY, _stateModelFty,
_resourceName);
```
### Description
If the state model defined in ZK under "LeaderStandby" has dropped as a
valid state, GenericLeaderStandby model will fail to transition and get into an
error state. It also cannot recover from error or dropped to offline as those
transitions are not defined either.
Participant Side log for failing to process OFFLINE-->DROPPED
```
2024/02/21 07:53:03.970 ERROR [HelixStateTransitionHandler]
[HelixTaskExecutor-message_handle_thread_36] [....] [] Unable to find method
for transition from OFFLINE to DROPPED in class
org.apache.helix.participant.GenericLeaderStandbyModel
```
CurrentState can also get stuck in ERROR state, fails to process
ERROR-->OFFLINE
```
INFO": "Unable to find method for transition from ERROR to OFFLINE in class
org.apache.helix.participant.GenericLeaderStandbyModel",
```
### Tests
- [] The following tests are written for this issue:
n/a
- The following is the result of the "mvn test" command on the appropriate
module:
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their
subject lines. In addition, my commits follow the guidelines from "[How to
write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
