zpinto opened a new pull request, #2772:
URL: https://github.com/apache/helix/pull/2772

   ### Issues
   
   - [ ] 
   
   ### Description
   
   - [ ] Replace the HELIX_ENABLED config with InstanceOperation while 
maintaining backwards compatibility with old APIs. Deprecate old APIs. 
HELIX_ENABLED = false will be respected for all InstanceOperations except 
SWAP_IN. This means user can expect to see all partitions go to OFFLINE when 
setting HELIX_ENABLED = false. When set to true, the controller will use 
InstanceOperation instead of considering the instance simply enabled.
   
   (Write a concise description including what, why, how)
   
   ### Tests
   
   - [x] Adjusted tests to use new APIs and kept tests using old APIs to ensure 
backwards compatibility
   
   ### Changes that Break Backward Compatibility (Optional)
   
   ### Commits
   
   - My commits all reference appropriate Apache Helix GitHub issues in their 
subject lines. In addition, my commits follow the guidelines from "[How to 
write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Code Quality
   
   - My diff has been formatted using helix-style.xml 
   (helix-style-intellij.xml if IntelliJ IDE is used)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to