junkaixue commented on code in PR #2735:
URL: https://github.com/apache/helix/pull/2735#discussion_r1525490257
##########
helix-core/src/test/java/org/apache/helix/integration/TestErrorReplicaPersist.java:
##########
@@ -103,10 +103,9 @@ public void testErrorReplicaPersist() throws
InterruptedException {
ClusterConfig clusterConfig =
configAccessor.getClusterConfig(CLUSTER_NAME);
clusterConfig.setErrorPartitionThresholdForLoadBalance(100000);
configAccessor.setClusterConfig(CLUSTER_NAME, clusterConfig);
-
+
for (int i = 0; i < (NODE_NR + 1) / 2; i++) {
_participants[i].syncStop();
- Thread.sleep(2000);
Review Comment:
Better not remove this, this wait time is for cluster converge. If you need
to fix this, would be good to put a verifier here.
##########
helix-core/src/test/java/org/apache/helix/integration/TestSchemataSM.java:
##########
@@ -56,7 +56,7 @@ public void testSchemataSM() throws Exception {
1, // partitions per resource
n, // number of nodes
0, // replicas
- "STORAGE_DEFAULT_SM_SCHEMATA", false); // don't rebalance
+ "MasterSlave", false); // don't rebalance
Review Comment:
Use LeaderStandby instead of non-inclusive one.
##########
helix-core/src/test/java/org/apache/helix/integration/TestSchemataSM.java:
##########
@@ -101,7 +101,7 @@ public void testSchemataSM() throws Exception {
for (int i = 0; i < n; i++) {
String instanceName = "localhost_" + (12918 + i);
Assert.assertNotNull(stateMap.get(instanceName));
- Assert.assertEquals(stateMap.get(instanceName), "MASTER");
+ Assert.assertEquals(stateMap.get(instanceName), i == 0 ? "MASTER" :
"SLAVE");
Review Comment:
Same here. If you touch it, better change the model
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
