himanshukandwal commented on PR #2778: URL: https://github.com/apache/helix/pull/2778#issuecomment-2000309076
> You should update the description or add comments: > > 1. We first sort on Preference List (does it have any special comparator?) > 2. We sort on StateModelDef > > it would be useful to add comments. Yes, updated the code with comments. Thanks Komal! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
