junkaixue commented on code in PR #2807:
URL: https://github.com/apache/helix/pull/2807#discussion_r1635306651
##########
meta-client/src/main/java/org/apache/helix/metaclient/recipes/leaderelection/LeaderElectionClient.java:
##########
@@ -97,7 +97,13 @@ public LeaderElectionClient(MetaClientConfig
metaClientConfig, String participan
LOG.info("Creating MetaClient for LeaderElectionClient");
if
(MetaClientConfig.StoreType.ZOOKEEPER.equals(metaClientConfig.getStoreType())) {
ZkMetaClientConfig zkMetaClientConfig = new
ZkMetaClientConfig.ZkMetaClientConfigBuilder().setConnectionAddress(
- metaClientConfig.getConnectionAddress()).setZkSerializer((new
LeaderInfoSerializer())).build();
+ metaClientConfig.getConnectionAddress())
+ .setZkSerializer((new LeaderInfoSerializer()))
+
.setSessionTimeoutInMillis(metaClientConfig.getSessionTimeoutInMillis())
+
.setMetaClientReconnectPolicy(metaClientConfig.getMetaClientReconnectPolicy())
+
.setConnectionInitTimeoutInMillis(metaClientConfig.getConnectionInitTimeoutInMillis())
+ .setAuthEnabled(metaClientConfig.isAuthEnabled())
+ .build();
Review Comment:
Why we don't have config validator? Or these are the optional fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
