junkaixue commented on code in PR #2834:
URL: https://github.com/apache/helix/pull/2834#discussion_r1681480488
##########
helix-gateway/src/main/proto/HelixGatewayService.proto:
##########
@@ -0,0 +1,52 @@
+syntax = "proto3";
+
+package proto.org.apache.helix.gateway;
+
+message SingleTransitionMessage {
+ enum TransitionType {
+ ADD_SHARD = 0;
+ DELETE_SHARD = 1;
+ CHANGE_ROLE = 2;
+ }
+ string transitionID = 1; // ID of transition message
+ TransitionType transitionType = 2; // Transition type for shard operations
+ string resourceID = 3; // Resource ID
+ string shardID = 4; // Shard to perform operation
+ string startState = 5; // Shard start state
Review Comment:
This should be optional as we decide to let user report their states.
##########
helix-gateway/src/main/proto/HelixGatewayService.proto:
##########
@@ -0,0 +1,52 @@
+syntax = "proto3";
+
+package proto.org.apache.helix.gateway;
+
+message SingleTransitionMessage {
+ enum TransitionType {
+ ADD_SHARD = 0;
+ DELETE_SHARD = 1;
+ CHANGE_ROLE = 2;
+ }
+ string transitionID = 1; // ID of transition message
+ TransitionType transitionType = 2; // Transition type for shard operations
+ string resourceID = 3; // Resource ID
+ string shardID = 4; // Shard to perform operation
+ string startState = 5; // Shard start state
+ string targetState = 6; // Shard target state.
+}
+
+message StateTransitionMessage{
Review Comment:
We call single transition message previously, then following naming should
be consistent. This should be called as TransitionMessages as well.
##########
helix-gateway/src/main/java/org/apache/helix/gateway/grpcService/HelixGatewayServiceService.java:
##########
@@ -0,0 +1,35 @@
+package org.apache.helix.gateway.grpcService;
Review Comment:
The package path should not contain any capital characters.
##########
helix-gateway/src/main/proto/HelixGatewayService.proto:
##########
@@ -0,0 +1,52 @@
+syntax = "proto3";
+
+package proto.org.apache.helix.gateway;
+
+message SingleTransitionMessage {
+ enum TransitionType {
+ ADD_SHARD = 0;
+ DELETE_SHARD = 1;
+ CHANGE_ROLE = 2;
+ }
+ string transitionID = 1; // ID of transition message
+ TransitionType transitionType = 2; // Transition type for shard operations
+ string resourceID = 3; // Resource ID
+ string shardID = 4; // Shard to perform operation
+ string startState = 5; // Shard start state
+ string targetState = 6; // Shard target state.
+}
+
+message StateTransitionMessage{
+ repeated SingleTransitionMessage request = 1;
+}
+
+message SingleReplicaStateTransitionStatus {
Review Comment:
Shall we ignore replica in the naming? It is asymmetrical for naming in
request/response. Also it is status of message also means for a replica already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
