junkaixue commented on code in PR #2840:
URL: https://github.com/apache/helix/pull/2840#discussion_r1684703183
##########
helix-gateway/src/main/proto/HelixGatewayService.proto:
##########
@@ -26,26 +26,25 @@ message SingleShardTransitionStatus {
optional string currentState = 3; // If it failed, what is the current
state it should reported as.
}
-// resource has list of replica
-
message SingleResourceState {
- string resource = 1;
- repeated SingleShardState SingleReplicaState= 2;
+ string resource = 1; // name of the resource
+ repeated SingleShardState SingleReplicaState = 2; // State of each shard
Review Comment:
shard not replica
##########
helix-gateway/src/main/proto/HelixGatewayService.proto:
##########
@@ -26,26 +26,25 @@ message SingleShardTransitionStatus {
optional string currentState = 3; // If it failed, what is the current
state it should reported as.
}
-// resource has list of replica
-
message SingleResourceState {
- string resource = 1;
- repeated SingleShardState SingleReplicaState= 2;
+ string resource = 1; // name of the resource
+ repeated SingleShardState SingleReplicaState = 2; // State of each shard
}
message SingleShardState {
- string shardaName = 1;
- string currentState = 2;
+ string shardaName = 1; // Name of the shard
Review Comment:
typo "sharda"
##########
helix-gateway/src/main/java/org/apache/helix/gateway/util/StateTransitionMessageTranslator.java:
##########
@@ -0,0 +1,8 @@
+package org.apache.helix.gateway.util;
+
+public class StateTransitionMessageTranslator {
+
+ public static void translateSTMsgToProto() {
Review Comment:
I would assume this should be interface instead of concrete class.
interface I am expecting was:
fromHelixToProto
fromProtoToHelix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
