frankmu commented on code in PR #2846:
URL: https://github.com/apache/helix/pull/2846#discussion_r1690582066
##########
helix-core/src/main/java/org/apache/helix/controller/rebalancer/condition/RebalanceConditionBuilder.java:
##########
@@ -0,0 +1,49 @@
+package org.apache.helix.controller.rebalancer.condition;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.function.BooleanSupplier;
+
+public class RebalanceConditionBuilder {
Review Comment:
Sure, can you share some code pointers on how to detect the config change or
topology change?
e.g. for config change, is it something like the following:
```
event.getEventType() == ClusterEventType.ClusterConfigChange
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
