GrantPSpencer commented on PR #2848: URL: https://github.com/apache/helix/pull/2848#issuecomment-2250585664
> @GrantPSpencer This test failed: Test failed: testDisablePartition(org.apache.helix.integration.TestDisablePartition) Time elapsed: 30.279 s <<< FAILURE! > > It is related to your change. Make sure this is fixed. I was not cleaning up the resources I added solely for the new test method (testDisableAllPartitions) in testDisablePartition class. This caused a downstream issue seen in the failed test. Pushing change now and will trigger a few cI runs on my personal fork to confirm not flaky -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org
