xyuanlu commented on code in PR #2868:
URL: https://github.com/apache/helix/pull/2868#discussion_r1701288194
##########
helix-gateway/src/main/java/org/apache/helix/gateway/participant/HelixGatewayParticipant.java:
##########
@@ -42,17 +43,20 @@
* for the participant and updates the state of the participant's shards upon
successful state
* transitions signaled by remote participant.
*/
-public class HelixGatewayParticipant {
+public class HelixGatewayParticipant implements HelixManagerStateListener {
public static final String UNASSIGNED_STATE = "UNASSIGNED";
private final HelixGatewayServiceProcessor _gatewayServiceProcessor;
private final HelixManager _participantManager;
+ private final Runnable _onDisconnectedCallback;
private final Map<String, Map<String, String>> _shardStateMap;
private final Map<String, CompletableFuture<Boolean>>
_stateTransitionResultMap;
private HelixGatewayParticipant(HelixGatewayServiceProcessor
gatewayServiceProcessor,
+ Runnable onDisconnectedCallback,
HelixManager participantManager, Map<String, Map<String, String>>
initialShardStateMap) {
_gatewayServiceProcessor = gatewayServiceProcessor;
_participantManager = participantManager;
Review Comment:
Not related to this change. May I suggest let's use `helixManager` as var
name? Since there is a ParticipantManager class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
